Add additional modulo in IfW_FlowField #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should finally fix the issue raised in PR#1702 and PR#1501. A second modulo was added because small negative values will cause the first modulo to return a value equal to NSteps which then causes the code to think the time is out of bounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to merge.
Feature or improvement description
This PR duplicates PR #1730 for the
rc-3.5.1branch to resolve an InflowWind bug where OpenFAST exits with an error indicating that the Grid3D wind field has been exhausted.Related issue, if one exists
#1746
Impacted areas of the software
InflowWind