AD: Bug Fix: Twist in blades 2 and 3 wrong when using Polar BEM #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does line 3615 in AeroDyn.f90 also need this change? https://github.com/ebranlard/openfast/blob/f/bladeTwistMissing23/modules/aerodyn/src/AeroDyn.f90#L3615 |
|
Yes, thanks a lot for spotting this! |
ebranlard
force-pushed
the
f/bladeTwistMissing23
branch
from
2bb5bc1
to
0fa7c6d
Compare
andrew-platt
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged
Feature or improvement description
In #2349 I introduced a bug in the Polar BEM when I introduced a wrapper function fo rthe calculation of the toe, twist cant angles. An index was missing, leading to only blade 1 having the correct twist.
Impacted areas of the software
AeroDyn - Polar BEM (currently untested)