-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗✨:kick off new fish shell CentOS devcontainer #28
🏗✨:kick off new fish shell CentOS devcontainer #28
Conversation
We took from official fish-shell project, which they use for building the fish shell itself; deterministic builds here we come! Signed-off-by: Derek Lewis <[email protected]>
removing previous incantation Signed-off-by: Derek Lewis <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
@DerekNonGeneric, suggest reading some more @OpenINF/ATeamGrimesAI while working on the roster:
|
> after yum install DOK-P1000 otherwise CI fails too
the remaining error failing ci check — Pin versions in yum install DOK-W1003 — is not one we can really consider being an error per se; i do not really think what is expected would be a practical practice, really… we will have to step up our automated dependency management skill first; like w/ commit queue & merge bots landing PRs, until then, we do not really want to deal w/ all those deps constantly changing… that would force us to keep shipping updates regularly, and then that would become our focus… |
This comment was marked as outdated.
This comment was marked as outdated.
@DerekNonGeneric, suggest making sure that this properly equips the developers using this container w/ tools neceessary in delivering what we have expectation on delivering; addresses OpenINF/openinf.github.io#106. |
we know the procedure on Debain, at least (hopefully)
uh oh, might've broke it, but we need:
|
y'know, it seems like getting too ambitious on an initial pr (that's expecting followups) perhaps was not the course of action; this pr now fits the description w/o getting into personal preference (wrt editor extensions, terminal profiles, documentation tooling, etc.) the CentOS 7 devcontainer runs and it's alive; we should build from here; a good starting point (and one that will hold my interest) has been effectively reached; the code that looks unused may be used later or not, we are still thinking on our feet, so keeping some boilerplate is not bad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
opening this as a draft due to WIP nature; untested, needs polish
Pull Request Purpose
Make a selection on the purpose(s) of your changes.
This PR contains the following:
Testing
Have you included any tests in your submission?
tests)
Breaking Changes
Have you modified any aspect public API surface (i.e., caused breakage)?
necessary)
Description
A concise recap summarily detailing what all are the changes being made.
We took from official fish-shell project, which they use for building the fish shell itself; deterministic builds here we come!
List of any relevant issue numbers: