illumos-gate: add patch to set cubic instead of sunreno congestion-co… #20482
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we need this patch? Isn't it possible to set this via tunables where needed? |
|
Because others (eg. FreeBSD 14.2, Debian Linux 12) have it as their default algorithm, too. |
|
Then why not to propose this change upstream? I believe we should not diverge in non-critical areas from the vanilla illumos-gate. Especially when it is extremely easy to run |
|
illumos-gate is ver conservative and I don't want to argue there. Most OI users don't know these details but suffer from ancient settings in illumos-gate / OI. |
|
You do not need to argue much. Just file a bug explaining how exactly users suffer and that should be enough as a first step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntrol algorithm