Editorial fixes to v1.1.1 repository #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed as the raml2doc tool has an issue with '©'.
This is needed as the raml2doc tool has an issue with '©'.
oic.core resolve $ref.
Each directory needs to contain both the License and the Disclaimer. - Add License and Disclaimer to schema directory. Each file needs to contain the full copyright text. - Incorporate the copyright text instead of including the file.
Fixed the files that didn't have the 'schemas' subfolder in the id. Fixed the files that didn't have the '#' at the end of the id that indicates a same document reference.
Various fixes on id's and incorporate legal content through includes.
Changes to various schema files to reflect alignment to OIC v1.1 reflected in various OIC Change Requests.
Align schemas to OIC v1.1 changes
Merge pull request #2 from rabardini/refactor
Merge Refactor onto Master branch
v1.1.0 Core Specification RAML/JSON files
… uuids and date-time
… uuids and date-time
Refresh to latest branch for Core
Fix "data" format type and fix collections. These where changes discussed and accepted during the Architecture 10/10/2016 teleconference.
As per the discussion in atg October 24, 2016, removed link tagging and added the "rep" keyword to the batch representation
The "rel" parameter needs to also be a multi value (repeatable) array as per RFC6690
made "di" and "ins" use reference to UUID definition instead of pattern property
fix typo in JSON that the editor didn't flag
readonly only applies to resource properties, not link parameter definitions. The "links" property of a collection resource is array of links with parameters. The links property is already made readonly through the oic.if.ll interface.
Removed the link tag and added "rep" keyword
Fix for missing closing bracket in oic.collection.batch-retrive-schema.json
Fix for invalid json schema
Fix allOf section in oic.collection-schema.json
Allow the "rel" link attribute to be either string or array
as agreed in the Taipei F2F meeting
all resource definitions need additionalproperties to be true for validation of composite resources
Update to master branch head
Fix for invalid json of oic.oic-link-schema.json
Update to head branch of master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Mitch:
"links": {
"type": "array",
"description": "Array of OIC web links that are the rule members, this is the script",
"items" : {
"allOf": [
{ "$ref": "oic.oic-link-schema.json#/definitions/oic.oic-link#" },
{ "required" : [ "ins" ] }
]
}
}
},
The “#” need to be removed.
"uuid": {
"description": "An identifier formatted according to IETF RFC 4122.",
"type":"string",
"format": "date-time",
"pattern": "^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}$"
},
I can’t recall if we agreed to keep the “format” for “uuid” but if we did, it should not be “date-time”.
"if": {
"type": "array",
"items": [
{
"type" : "string",
"enum" : ["oic.if.baseline", "oic.if.ll", "oic.if.b", "oic.if.lb", "oic.if.rw", "oic.if.r", "oic.if.a", "oic.if.s" ]
}
],
"minItems": 1,
"readOnly": true,
"description": "The interface set supported by this resource"
},
oic.if.lb was removed from the core spec.
"sec": {
"readOnly": true,
"description": "Specifies if security needs to be turned on when looking to interact with the Resource",
"type": "boolean"
},
Per CR 48, we had agreed that the default value of “sec” is false. The schema file use to include: “default”: false. Do we no longer include the default value in the schema file?