Skip to content

Commit

Permalink
Remove yaml changes and one code change
Browse files Browse the repository at this point in the history
  • Loading branch information
cherylking committed Aug 21, 2023
1 parent 02bcb8b commit e89efed
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ jobs:
- name: Checkout ci.common
uses: actions/checkout@v3
with:
repository: cherylking/ci.common
ref: addSkipInstallFeature
repository: OpenLiberty/ci.common
path: ci.common
- name: Checkout ci.ant
uses: actions/checkout@v3
Expand Down Expand Up @@ -120,7 +119,7 @@ jobs:
- name: Clone ci.ant, ci.common, ci.gradle repos to C drive
run: |
cp -r D:/a/ci.gradle/ci.gradle C:/ci.gradle
git clone https://github.com/cherylking/ci.common.git --branch addSkipInstallFeature --single-branch C:/ci.common
git clone https://github.com/OpenLiberty/ci.common.git C:/ci.common
git clone https://github.com/OpenLiberty/ci.ant.git C:/ci.ant
# Cache mvn/gradle packages
- name: Cache Maven packages
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -921,13 +921,13 @@ class DevTask extends AbstractFeatureTask {
ProjectConnection gradleConnection = initGradleProjectConnection();
BuildLauncher gradleBuildLauncher = gradleConnection.newBuild();
try {
gradleBuildLauncher.addArguments("--exclude-task", "libertyCreate"); // deploy dependsOn libertyCreate which is finalizedBy installFeature
if (container) {
gradleBuildLauncher.addArguments(CONTAINER_PROPERTY_ARG)
// Skip installFeature since it is not needed here in container mode.
// Container mode should call installFeature separately with the containerName parameter where needed.
gradleBuildLauncher.addArguments("--exclude-task", "installFeature");
} else if (skipInstallFeature) {
gradleBuildLauncher.addArguments("--exclude-task", "libertyCreate"); // deploy dependsOn libertyCreate which is finalizedBy installFeature
gradleBuildLauncher.addArguments("--exclude-task", "installFeature");
}
runGradleTask(gradleBuildLauncher, 'deploy');
Expand Down

0 comments on commit e89efed

Please sign in to comment.