Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create XML Validaton Tests #30500

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

volosied
Copy link
Member

@volosied volosied commented Jan 8, 2025

Tests will need to be re-enabled once #30527 is fixed

With this PR, we can close #30010 since the 4.1 tests pass under the EE11 repeat.

@volosied
Copy link
Member Author

volosied commented Jan 8, 2025

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Jan 8, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 7 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@volosied
Copy link
Member Author

volosied commented Jan 9, 2025

JSF tests passed. Only one failure in the com.ibm.ws.jbatch.open_fat bucket.

@volosied
Copy link
Member Author

volosied commented Jan 10, 2025

!build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 7 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@volosied
Copy link
Member Author

Without skipping repeats: image
image

The EE8 server ran into this error, so it didn't reach the validation step, I believe:

[ERROR   ] SRVE0285E: Exception caught while destroying context: java.lang.IllegalStateException: No Factories configured for this Application. This happens if the faces-initialization does not work at all - make sure that you properly include all configuration settings necessary for a basic faces application and that all the necessary libs are included. Also check the logging output of your web application and your container for any exceptions!
If you did that and find nothing, the mistake might be due to the fact that you use some special web-containers which do not support registering context-listeners via TLD files and a context listener is not setup in your web.xml.
A typical config looks like this;
<listener>
  <listener-class>org.apache.myfaces.webapp.StartupServletContextListener</listener-class>
</listener>

	at javax.faces.FactoryFinder._getFactory(FactoryFinder.java:310)
	at javax.faces.FactoryFinder.getFactory(FactoryFinder.java:230)
	at org.apache.myfaces.context.servlet.FacesContextImplBase.getApplication(FacesContextImplBase.java:169)
	at [internal classes]

The main goal was to create test and have them pass on 4.1. Future work will be done via #30527

I have to investigate each feature separately.

Copy link
Member

@pnicolucci pnicolucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are only enabled where they pass currently. A follow on issue will be used to investigate the failures.

@volosied volosied merged commit 7a4ead2 into OpenLiberty:integration Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faces 4.1: Update Schemas for MyFaces 4.1
3 participants