Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework async send tests part1 #30511

Open
wants to merge 11 commits into
base: integration
Choose a base branch
from
Open

Rework async send tests part1 #30511

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5bb2c0e
Use scoped Connection and temporaryQueue in testJMS1AsyncSendException
sakerl Dec 18, 2024
086ae0c
Add logging to testJMS1AsyncSendException
sakerl Dec 18, 2024
3ff4e78
Use the correct queueConnection in testJMS1AsyncSendException
sakerl Dec 18, 2024
638160a
Use scoped queueConnection in testJMS1AsyncSendNoDestination
sakerl Dec 18, 2024
e525fa8
Add logging to testJMS1AsyncSendNoDestination
sakerl Dec 18, 2024
fce4563
Use scoped Connection and temporaryQueue in
sakerl Dec 18, 2024
87bc96d
Add logging to testJMS1AsyncSendNullListener
sakerl Dec 18, 2024
c225457
Use scoped Connection in
sakerl Dec 18, 2024
c1a47cb
Add logging to
sakerl Dec 30, 2024
b00a920
Update copyright dates in JMS1AsyncSend
sakerl Jan 9, 2025
2b4edbf
Add connection.start() for scoped connections
sakerl Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 78 additions & 13 deletions ...1AsyncSendClient.jar/src/com/ibm/ws/messaging/open_clientcontainer/fat/JMS1AsyncSend.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* ============================================================================
* Copyright (c) 2019, 2024 IBM Corporation and others.
* Copyright (c) 2019, 2025 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
* which accompanies this distribution, and is available at
Expand Down Expand Up @@ -181,21 +181,37 @@ public void testJMS1ExceptionMessageThreshhold() throws JMSException, TestExcept
@ClientTest
public void testJMS1AsyncSendException() throws JMSException, TestException {
//Util.setLevel(Level.FINEST);

Util.CODEPATH();

try (QueueSession queueSession = queueConnection_.createQueueSession(false, javax.jms.Session.AUTO_ACKNOWLEDGE)) {
BasicCompletionListener completionListener = new BasicCompletionListener();
try ( QueueConnection queueConnection = queueConnectionFactory_.createQueueConnection();
QueueSession queueSession = queueConnection.createQueueSession(false, javax.jms.Session.AUTO_ACKNOWLEDGE)) {

Util.TRACE("Getting Test objects");

BasicCompletionListener completionListener = new BasicCompletionListener();
Queue queue = queueSession.createTemporaryQueue();

queueConnection.start();

try {
MessageProducer producer = queueSession.createProducer(null);
producer.send(queueOne_, null, completionListener);

Util.TRACE("Sending null Message. Expected to fail");
producer.send(queue, null, completionListener);

Util.LOG("Send message did not throw expected Exception");
throw new TestException("Expected MessageFormatException not thrown, completionListener state="+completionListener.formattedState());
} catch (MessageFormatException e) {
if (completionListener.completionCount_ != 0 )
throw new TestException("Non zero completionCount completionListener.formattedState:"+completionListener.formattedState());
if (completionListener.exceptionCount_ != 0)
throw new TestException("Non zero exceptionCount completionListener.formattedState:"+completionListener.formattedState());
}
} finally {
clearQueue(queueOne_, methodName(), 0);
}
catch ( JMSException | TestException e) {
Util.LOG("Exception thrown during test", e);
throw e;
}

reportSuccess();
Expand Down Expand Up @@ -410,13 +426,23 @@ public void testJMS1CloseConnection() throws JMSException, InterruptedException,
@ClientTest
public void testJMS1AsyncSendUnidentifiedProducerUnidentifiedDestination() throws JMSException, InterruptedException, TestException {

try (QueueSession session = queueConnection_.createQueueSession(false, javax.jms.Session.AUTO_ACKNOWLEDGE)) {
Util.CODEPATH();

try ( QueueConnection queueConnection = queueConnectionFactory_.createQueueConnection();
QueueSession session = queueConnection.createQueueSession(false, javax.jms.Session.AUTO_ACKNOWLEDGE)) {

Util.TRACE("Getting Test objects");
TextMessage sentMessage = session.createTextMessage(methodName() + " at " + new Date());
MessageProducer producer = session.createProducer(null);

queueConnection.start();

BasicCompletionListener completionListener = new BasicCompletionListener();
try {
Util.TRACE("Sending message to null Destination. Expected to fail");
producer.send(null, sentMessage, completionListener);

Util.LOG("Send message did not throw expected Exception");
throw new TestException("InvalidDestinationException not thrown");
} catch (InvalidDestinationException e) {
// Expected Exception.
Expand All @@ -427,67 +453,106 @@ public void testJMS1AsyncSendUnidentifiedProducerUnidentifiedDestination() throw
if (!completionListener.waitFor(0, 0))
throw new TestException("Unexpected completion notification received, completionListener.formattedState:" + completionListener.formattedState());
}
catch (JMSException | TestException e) {

Util.LOG("Exception thrown during test", e);
throw e;

}

reportSuccess();
}

@ClientTest
public void testJMS1AsyncSendNullListener() throws JMSException, TestException {

try (QueueSession session = queueConnection_.createQueueSession(false, javax.jms.Session.AUTO_ACKNOWLEDGE)) {
Util.CODEPATH();

try (QueueConnection queueConnection = queueConnectionFactory_.createQueueConnection();
QueueSession session = queueConnection.createQueueSession(false, javax.jms.Session.AUTO_ACKNOWLEDGE)) {

Util.TRACE("Creating test objects");

Queue queue = session.createTemporaryQueue();
TextMessage sentMessage = session.createTextMessage(methodName() + " at " + new Date());
MessageProducer producer = session.createProducer(queueOne_);
MessageProducer producer = session.createProducer(queue);

queueConnection.start();

try {
Util.LOG("Sending message with null CompletionListener");
producer.send(sentMessage, null);
throw new TestException("IllegalArgumentException not thrown.");
} catch (IllegalArgumentException e) {
// Expected Exception.
Util.TRACE(e);
}
} finally {
clearQueue(queueOne_, methodName(), 0);
}
catch (JMSException | TestException e) {

Util.LOG("Exception thrown during test", e);
throw e;

}

reportSuccess();
}

@ClientTest
public void testJMS1AsyncSendNoDestination() throws JMSException, TestException {

Util.CODEPATH();

try (QueueSession session = queueConnection_.createQueueSession(false, javax.jms.Session.AUTO_ACKNOWLEDGE)) {
try (QueueConnection queueConnection = queueConnectionFactory_.createQueueConnection();
QueueSession session = queueConnection.createQueueSession(false, javax.jms.Session.AUTO_ACKNOWLEDGE)) {

Util.TRACE("Creating test objects");

TextMessage sentMessage = session.createTextMessage(methodName() + " at " + new Date());
MessageProducer producer = session.createProducer(null);

BasicCompletionListener completionListener = new BasicCompletionListener();

queueConnection.start();

try {
Util.LOG("Test no destination method 1");
producer.send(sentMessage, completionListener);
throw new TestException("UnsupportedOperationException 1 not thrown");
} catch (UnsupportedOperationException e) {
// Expected Exception.
Util.TRACE(e);
}
try {
Util.LOG("Test null destination method 1");
producer.send(null, sentMessage, completionListener);
throw new TestException("InvalidDestinationException 1 not thrown");
} catch (InvalidDestinationException e) {
// Expected Exception.
Util.TRACE(e);
}
try {
Util.LOG("Test no destination method 2");
producer.send(sentMessage, DeliveryMode.PERSISTENT, 0, 10000, completionListener);
throw new TestException("UnsupportedOperationException 2 not thrown");
} catch (UnsupportedOperationException e) {
// Expected Exception.
Util.TRACE(e);
}
try {
Util.LOG("Test null destination method 2");
producer.send(null, sentMessage, DeliveryMode.PERSISTENT, 0, 10000, completionListener);
throw new TestException("InvalidDestinationException 2 not thrown");
} catch (InvalidDestinationException e) {
// Expected Exception.
Util.TRACE(e);
}
}
catch (JMSException | TestException e) {

Util.LOG("Exception thrown during test", e);
throw e;

}

reportSuccess();
}
Expand Down