Disallow deprecated entity attribute types #30535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is best if Jakarta Data disallows the entity attributes that are deprecated by JPA 3.2 so that customers don't start using them only to later see them removed.
We had one test case that was using a deprecated type: java.sql.Timestamp
It was using it as a Version attribute, so I tried switching to java.time.LocalDateTime, which has a similar meaning and is listed as supported by JPA 3.2. EclipseLink rejected it, so I reported that to the JPA team and placed a TODO comment in the code pointing to the tracking issue and temporarily using
Long
instead.release bug
label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).