Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow deprecated entity attribute types #30535

Conversation

njr-11
Copy link
Contributor

@njr-11 njr-11 commented Jan 10, 2025

It is best if Jakarta Data disallows the entity attributes that are deprecated by JPA 3.2 so that customers don't start using them only to later see them removed.

We had one test case that was using a deprecated type: java.sql.Timestamp
It was using it as a Version attribute, so I tried switching to java.time.LocalDateTime, which has a similar meaning and is listed as supported by JPA 3.2. EclipseLink rejected it, so I reported that to the JPA team and placed a TODO comment in the code pointing to the tracking issue and temporarily using Long instead.

@njr-11
Copy link
Contributor Author

njr-11 commented Jan 10, 2025

#build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 4 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_on7ncNAzEe-f-sI4gb7_Pw

Target locations of links might be accessible only to IBM employees.

@njr-11 njr-11 merged commit 04f273f into OpenLiberty:integration Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants