encode player name before sending to game (#138)

OpenLiberty · Apr 12, 2023 · 7631c33 · 7631c33
1 parent 66b89ae
commit 7631c33
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/services/client/src/hooks/useGame.ts b/services/client/src/hooks/useGame.ts
@@ -174,7 +174,7 @@ const useGame = (gameSocketURL: string, durationInSeconds: number) => {
     if (gameState === GameState.NotStarted) {
       setPlayerName(playerName);
       setGameMode(gameMode);
-      sendMessage(Event.Start, [playerName, gameMode].join(","));
+      sendMessage(Event.Start, [encodeURIComponent(playerName), gameMode].join(","));
       setGameState(GameState.InGame);
       startTimer();
     }

diff --git a/services/game/src/main/java/io/openliberty/spacerover/game/websocket/server/GameServer.java b/services/game/src/main/java/io/openliberty/spacerover/game/websocket/server/GameServer.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2022 IBM Corporation and others.
+ * Copyright (c) 2022, 2023 IBM Corporation and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -11,6 +11,9 @@
 package io.openliberty.spacerover.game.websocket.server;
 
 import java.io.IOException;
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
+import java.nio.charset.StandardCharsets;
 import java.util.Arrays;
 import java.util.logging.Level;
 import java.util.logging.Logger;
@@ -143,6 +146,12 @@ private String getErrorMessage(final String errorText) {
 
 	private void startGame(final String[] properties) {
 		String playerId = properties[0];
+		try {
+			playerId = URLDecoder.decode(playerId, StandardCharsets.UTF_8.name());
+		} catch (UnsupportedEncodingException e) {
+			// utf-8 always supported
+		}
+
 		int gameMode = Integer.parseInt(properties[1]);
 		LOGGER.log(Level.INFO, "Start Game received for player ID: {0}, GameMode: {1}",
 				new Object[] { playerId, gameMode });