Junit5 support #22
Open
Junit5 support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Created Custom TestResult interface and Implementation to pass to set the TestResult of the test instance * Created a TestWatcher implementation to catch test failure and successes since JUnit doesn't provide their own test result * Added RegisterExtension Annotation to BaseGenericTest to register the Custom test watcher programmatically so that we can provide the test instance in the constructor * Added appropriate Annotations for test lifecycle to BaseTest along with ExtensionContext and TestResult to replace ITestContext and ITestResult used by TestNG * Created Test to see if junit and TestNG can be used in the same test class * Created Copy of Test class with many tests using JUnit * Updated base pom to include junit-api and junit-engine dependencies * Created a properties file to run the JUnit tests in parallel
* Removed threadlocal since TestWatcher is created for each test
# Conflicts: # jmaqs-base/pom.xml # maqs-base/src/main/java/com/cognizantsoftvision/maqs/base/BaseTest.java # maqs-base/src/test/java/com/cognizantsoftvision/maqs/base/JUnit_BaseTestObjectUnitTest.java
# Conflicts: # maqs-base/src/main/java/com/cognizantsoftvision/maqs/base/BaseTest.java # maqs-base/src/test/java/com/cognizantsoftvision/maqs/base/BaseTestUnitTest.java
# Conflicts: # openmaqs-base/src/main/java/io/github/openmaqs/base/BaseTest.java # openmaqs-base/src/main/java/io/github/openmaqs/base/interfaces/JunitTestResult.java # openmaqs-base/src/main/java/io/github/openmaqs/base/interfaces/TestResult.java # openmaqs-base/src/main/java/io/github/openmaqs/base/watcher/JunitTestWatcher.java # openmaqs-base/src/test/java/io/github/openmaqs/base/junit/JUnitBaseGenericTestUnitTest.java # openmaqs-base/src/test/java/io/github/openmaqs/base/junit/JUnitBaseTestObjectUnitTest.java # openmaqs-base/src/test/resources/junit-platform.properties
Open
|
SonarCloud Quality Gate failed. |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add junit5 support to allow junit to run