-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support/polars #49
Draft
singjc
wants to merge
14
commits into
OpenMS:main
Choose a base branch
from
singjc:support/polars
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Support/polars #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…single tuple everytime
…hrough the unified dataframe interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to see how feasible it is to add support for polars dataframes. There are two approaches I can think of to do this.
use the
.to_pandas()
method in polars to convert the polars dataframe to a pandas dataframe. This is the easiest, but requires the user to need both polars and pandas, but maybe that's okay.use a unified dataframe class that wraps either a pandas or polars dataframe, and mimics the behaviour of pandas, to avoid having to change all the internal plotting that uses pandas notation.
This PR is implementing the latter to see whether it's easy enough and feasible to do.
I am also testing registering a namespace to a polars dataframe, so we can do something like
However, this currently only registers the namespace and works ifNot sure why, may be because this is how we define the entrypoint in our pyproject.toml.^ Had to just add the import for the
_dataframe
module to the__init__.py
file to register the namespace for polarsAny thoughts/comments/suggestions are welcome.