PHP84: ignore deprecated E_STRICT (#4289)

* fix for php84 deprecated E_STRICT * baseline * Update app/code/core/Mage/Core/functions.php Co-authored-by: Ng Kiat Siong <[email protected]> * baseline --------- Co-authored-by: Ng Kiat Siong <[email protected]>
OpenMage · Oct 23, 2024 · 94ee1fc · 94ee1fc
1 parent 5207750
commit 94ee1fc
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/code/core/Mage/Core/functions.php b/app/code/core/Mage/Core/functions.php
@@ -120,7 +120,7 @@ function mageCoreErrorHandler($errno, $errstr, $errfile, $errline)
     // PEAR specific message handling
     if (stripos($errfile . $errstr, 'pear') !== false) {
         // ignore strict and deprecated notices
-        if (($errno == E_STRICT) || ($errno == E_DEPRECATED)) {
+        if ((PHP_VERSION_ID < 80400 && $errno == E_STRICT) || ($errno == E_DEPRECATED)) {
             return true;
         }
         // ignore attempts to read system files when open_basedir is set
@@ -165,7 +165,7 @@ function mageCoreErrorHandler($errno, $errstr, $errfile, $errline)
         case E_USER_NOTICE:
             $errorMessage .= 'User Notice';
             break;
-        case E_STRICT:
+        case 2048: // E_STRICT prior to PHP8.4
             $errorMessage .= 'Strict Notice';
             break;
         case E_RECOVERABLE_ERROR: