-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template files to phpstan checks #4245
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # .phpstan.dist.baseline.neon
# Conflicts: # .phpstan.dist.baseline.neon
@@ -9,13 +9,14 @@ | |||
* @category design | |||
* @package default_default | |||
* @copyright Copyright (c) 2006-2020 Magento, Inc. (https://www.magento.com) | |||
* @copyright Copyright (c) 2018-2022 The OpenMage Contributors (https://www.openmage.org) | |||
* @copyright Copyright (c) 2018-2024 The OpenMage Contributors (https://www.openmage.org) | |||
* @license https://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0) | |||
*/ | |||
?> | |||
<?php | |||
/** | |||
* @see Mage_Bundle_Block_Adminhtml_Sales_Order_Items_Renderer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible to remove line 18?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see annotation is in lot of files and its used for phpdocumentor. I'd keep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about consistency? The see
annotation is also not in a lot of files. For consistency, is it better to remove?
There is an error in a template file reported recently: Ignored error pattern #^Variable |
Description (*)
Check template files with phpstan.
Yeah, 11k baseline is not nice, but that will be reduced during days. (help welcome to add doc blocks to template files!)
Related Pull Requests