-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Mage_Sendfriend
#4274
base: main
Are you sure you want to change the base?
Remove Mage_Sendfriend
#4274
Conversation
Orphaned references in magento-lts/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Checktype.php Lines 32 to 39 in a5a8527
email template: ACL resource: magento-lts/app/code/core/Mage/Adminhtml/etc/adminhtml.xml Lines 200 to 203 in a5a8527
However, removing the above would break |
Alternative extension: https://github.com/pyrroman/social-sharing-button-for-magento |
@kiatng Thanks. I have seen that sendfriend has some references in Mage_Reports observers, but i completly missed that. |
Thanks. This will be mentioned in documention :) |
There is also ...
|
Added to #4156 |
# Conflicts: # app/code/core/Mage/Sendfriend/etc/system.xml
What is the problem with it? Please test ddev composer localdev https://github.com/OpenMage/module-mage-sendfriend
ddev composer require openmage/module-mage-sendfriend:dev-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope the PR covers all records and nothing is left behind.
I can ensure there is code left behind. Observer from Mage_Reports eg ... but nothing that should rely on removed code. |
Description (*)