Fixes Mage_Core_Helper_Url::removeRequestParam()

[sreichel]

Description (*)

Mage_Core_Helper_Url::removeRequestParam() uses preg_replace or str_replace that can lead to malformed urls for partial matches.

Fixed Issues (if relevant)

1. Fixes removeRequestParam called by setBeforeAuthUrl messed up Query if ___SID is used #4294

Manual testing scenarios (*)

$url = 'https://example.com?___SID=S&SID=S&foo=bar&boo=baz';
Mage::helper('core/url')->removeRequestParam(
    $url,
    Mage::getSingleton('core/session')->getSessionIdQueryParam()
);

getSessionIdQueryParam() returns SID, that should be removed.

Expected

https://example.com?___SID=S&foo=bar&boo=baz

Current

https://example.com?___foo=bar&boo=baz

[ADDISON74]

@Hanmac - is this PR solving your issue? I tested and it works.

[Hanmac]

Maybe return early if the URL doesn't have '?'

[sreichel]

Yep. Updated.