[PHP 8.4] fputcsv() - The $escape parameter must be provided as its default value will change #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated. The PHP default value for the escape parameter is '\\' and I declared it at the beginning in certain files.
Deprecated. Deprecated. The $escape parameter must be provided as its default value will change.
Deprecated. The $escape parameter must be provided as its default value will change.
…ct.php Deprecated. The $escape parameter must be provided as its default value will change.
Deprecated. The $escape parameter must be provided as its default value will change.
github-actions
bot
added
Component: lib/Varien
ADDISON74
commented
Oct 19, 2024
sreichel
reviewed
Oct 20, 2024
Co-authored-by: Sven Reichel <[email protected]>
|
Pls run |
|
@sreichel - All green now. |
sreichel
approved these changes
Oct 20, 2024
kiatng
approved these changes
Oct 22, 2024
fballiano
added a commit
to MahoCommerce/maho
that referenced
this pull request
Oct 22, 2024
fballiano
added a commit
to MahoCommerce/maho
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with PHP version 8.4 the fifth parameter of the fputcsv() function must be specified, otherwise the following message will be displayed
The PHP default value for the escape parameter is
'\\'and I declared it at the beginning in some files.Since we support the PHP version 7.4, I did not use
escape:in front of the variable like others who provided similar solutions.