Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality: added PHPMD, updated workflow #4303

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Code quality: added PHPMD, updated workflow #4303

wants to merge 58 commits into from

Commits on Oct 20, 2024

  1. added phpmd to workflow

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    5ac5440 View commit details
    Browse the repository at this point in the history

  2. replaced variabvĺe $_item

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    fc0d658 View commit details
    Browse the repository at this point in the history

  3. replaced variabvĺe $_rss_url

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    000728a View commit details
    Browse the repository at this point in the history

  4. replaced variabvĺe $_storeIds

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    a771a71 View commit details
    Browse the repository at this point in the history

  5. replaced variabvĺe $_buyRequest

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    e83e1c1 View commit details
    Browse the repository at this point in the history

  6. replaced variabvĺe $_typeId

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    cd824bd View commit details
    Browse the repository at this point in the history

  7. replaced variabvĺe $_serviceCode

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    e143853 View commit details
    Browse the repository at this point in the history

  8. replaced variabvĺe $access_key

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    770cd93 View commit details
    Browse the repository at this point in the history

  9. replaced variabvĺe $method_arr

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    03f7ac0 View commit details
    Browse the repository at this point in the history

  10. replaced variabvĺe $font_size

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    450fe16 View commit details
    Browse the repository at this point in the history

  11. phpcs

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    2362d4b View commit details
    Browse the repository at this point in the history

  12. phpstan

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    580df70 View commit details
    Browse the repository at this point in the history

  13. fix phpunit workflow

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    339f5ac View commit details
    Browse the repository at this point in the history

  14. phpstan baseline

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    dc1ac16 View commit details
    Browse the repository at this point in the history

  15. tmp - disabled ShortVariable phpmd rule

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    10cef65 View commit details
    Browse the repository at this point in the history

  16. phpmd - ignore long class/variable names

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    56d33c7 View commit details
    Browse the repository at this point in the history

  17. phpmd - ignore BooleanGetMethodName

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    8954a68 View commit details
    Browse the repository at this point in the history

  18. replaced variabvĺe $increment_id

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    1fc9753 View commit details
    Browse the repository at this point in the history

  19. replaced variabvĺe $_profilerKey

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    0b6d938 View commit details
    Browse the repository at this point in the history

  20. replaced variabvĺe $_option

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    b29e132 View commit details
    Browse the repository at this point in the history

  21. replaced variabvĺe $drawing_text

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    b9a9a66 View commit details
    Browse the repository at this point in the history

  22. replaced variabvĺe $read_adapter

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    1d2a7bf View commit details
    Browse the repository at this point in the history

  23. replaced variabvĺe $rules_set

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    2e121ad View commit details
    Browse the repository at this point in the history

  24. replaced variabvĺe $select_id

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    8764ff2 View commit details
    Browse the repository at this point in the history

  25. replaced variabvĺe $currency_code

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    8b5365b View commit details
    Browse the repository at this point in the history

  26. replaced variabvĺe $_selection

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    aaeba5f View commit details
    Browse the repository at this point in the history

  27. replaced variabvĺe $_checkedPaths

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    444e7b5 View commit details
    Browse the repository at this point in the history

  28. replaced variabvĺe $_optionId

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    0bc8539 View commit details
    Browse the repository at this point in the history

  29. replaced variabvĺe $url_prefix

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    bca910f View commit details
    Browse the repository at this point in the history

  30. replaced variabvĺe $logo_src

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    d155cd5 View commit details
    Browse the repository at this point in the history

  31. replaced variabvĺe $_printValue

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    d53cf72 View commit details
    Browse the repository at this point in the history

  32. replaced variabvĺe $entity_id

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    f0cc586 View commit details
    Browse the repository at this point in the history

  33. replaced variabvĺe $_key

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    21528cd View commit details
    Browse the repository at this point in the history

  34. replaced variabvĺe $_value

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    35c69e3 View commit details
    Browse the repository at this point in the history

  35. replaced variabvĺe $item_id

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    4388ee4 View commit details
    Browse the repository at this point in the history

  36. replaced variable $tax_amount

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    a5a4270 View commit details
    Browse the repository at this point in the history

  37. replaced variable $tax_info

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    865398e View commit details
    Browse the repository at this point in the history

  38. replaced variable ...

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    2c02f7c View commit details
    Browse the repository at this point in the history

  39. replaced variable $total_reviews

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    261df7e View commit details
    Browse the repository at this point in the history

  40. replaced variable $_truncatedValue

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    489a9a0 View commit details
    Browse the repository at this point in the history

  41. replaced variable ...

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    e94f07e View commit details
    Browse the repository at this point in the history

  42. replaced variable ...

    @sreichel
    sreichel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    ca2bf73 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. replaced variable ...

    @sreichel
    sreichel committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    eea26d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. replaced variable ...

    @sreichel
    sreichel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d96173e View commit details
    Browse the repository at this point in the history

  2. update

    @sreichel
    sreichel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    67436e5 View commit details
    Browse the repository at this point in the history

  3. copyright dates

    @sreichel
    sreichel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c5d8829 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/phpmd-workflow' into phpmd-workflow 

    # Conflicts:
#	app/code/core/Mage/Adminhtml/controllers/Cms/Wysiwyg/ImagesController.php
    @sreichel
    sreichel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1a1b17d View commit details
    Browse the repository at this point in the history

  5. fix

    @sreichel
    sreichel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b61b3c5 View commit details
    Browse the repository at this point in the history

  6. rector

    @sreichel
    sreichel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d8f0071 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Merge branch 'main' into phpmd-workflow

    @sreichel
    sreichel committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    027d63c View commit details
    Browse the repository at this point in the history

  2. updated commands

    @sreichel
    sreichel committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a7046a7 View commit details
    Browse the repository at this point in the history

  3. updated commands

    @sreichel
    sreichel committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2a28f39 View commit details
    Browse the repository at this point in the history

  4. removed some phpcs comments

    @sreichel
    sreichel committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f3d99b5 View commit details
    Browse the repository at this point in the history

  5. added phpcs default config (for phpstorm)

    @sreichel
    sreichel committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8affb0e View commit details
    Browse the repository at this point in the history

  6. added github label

    @sreichel
    sreichel committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b26e111 View commit details
    Browse the repository at this point in the history

  7. phpcs

    @sreichel
    sreichel committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1ca6c02 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into phpmd-workflow

    @sreichel
    sreichel authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ab4cc2f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into phpmd-workflow

    @sreichel
    sreichel authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1350ad0 View commit details
    Browse the repository at this point in the history