Dont show disabled modules in "Disable Modules Output" config

[sreichel]

Description (*)

Don't show disabled modules in admin - system - config - advanced - advanced

Manual testing scenarios (*)

1. disable a module
2. flush cache
3. go to admin - system - config - advanced - advanced

Disabled module is still there.

[addison74]

Tested and it works as expected.

[kiatng]

Instead of not showing, is it better to inform the users that the module is inactivated in the global config? An example:

[sreichel]

Thought about it, but it makes no sense.

• it is only displayed if it is still there in filesystem
• it is disabled. Its confusing.

I put it on draft b/c ...

• pass the modules array to observer (not only array keys)
• add observer
• hide disabled modules there

[sreichel]

Instead of not showing, is it better to inform the users that the module is inactivated in the global config? An example:

I tried, but it would require some more changes.

[kiatng]

Alternative:

   // File app/code/core/Mage/Adminhtml/Block/System/Config/Form/Fieldset/Modules/DisableOutput.php
    protected function _getFieldHtml($fieldset, $moduleName)
    {
        $isInactive = (string) Mage::getConfig()->getNode('modules')->$moduleName->active !== 'true';
        // ...
        $field = $fieldset->addField(
            $moduleName,
            'select',
            [
                'name'          => 'groups[modules_disable_output][fields][' . $moduleName . '][value]',
                // ...
                'disabled'      => $isInactive,
                'title'         => $isInactive ? 'Inactivated in /etc/modules' : '',
        //...

[sreichel]

Wouldnt this not bypass the observers?

[kiatng]

Wouldnt this not bypass the observers?

Yes, observer is not required. And if you want to not show the modules: if ($isInactive) return ''. The is active check is microseconds. It's a simpler implementation, no additional loop on modules.

[sreichel]

The is active check is microseconds.

I've tested it. Running Mage::getConfig()->getNode('modules') 60 times is far slower.

[kiatng]

$moduleName = 'Mage_Core';
$isInactive = (string) Mage::getConfig()->getNode('modules')->$moduleName->active !== 'true';

My tests:

1. with all cache disabled, 5 microseconds
2. with all cache enabled, 8 microseconds, yes it's worst!

Really weird. Is it just me or for you too?

[justinbeaty]

$moduleName = 'Mage_Core';
$isInactive = (string) Mage::getConfig()->getNode('modules')->$moduleName->active !== 'true';

My tests:

1. with all cache disabled, 5 microseconds
2. with all cache enabled, 8 microseconds, yes it's worst!

Really weird. Is it just me or for you too?

I actually don’t think the modules xml section is cached at all, probably so you can disable a broken module. But I’m not at my desk to confirm this.

[kiatng]

Another test:

        $modules = array_keys(Mage::getConfig()->getNode('modules')->asArray()); // 88 elements
        foreach ($modules as $moduleName) {
            $result[$moduleName] = (string) Mage::getConfig()->getNode('modules')->$moduleName->active !== 'true';
        }

1. Config cache disabled, 650 microseconds
2. Config cache enabled, 930 microseconds, it's better to disable cache?

[sreichel]

My tests:

require_once('app/Mage.php');
umask(0);
Mage::app()->loadArea('adminhtml'); #to call the observer

function test4305_Observer() {
    $test = new Mage_Adminhtml_Block_System_Config_Form_Fieldset_Modules_DisableOutput();
    $test->getModules();
}

function test4305_Config() {
    for ($i = 0; $i <= 60; $i++) {
        $isInactive = (string)Mage::getConfig()->getNode('modules')->Mage_Core->active !== 'true';
    }
}

---

• Config cache disabled, 650 microseconds

• Config cache enabled, 930 microseconds, it's better to disable cache?

No.

Config cache enabled (last 5) vs config cache disabled.

I'd recommand to test #4325.