Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated message for strlen first value null #4306

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

leissbua
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: ImportExport Relates to Mage_ImportExport label Oct 24, 2024
@ADDISON74
Copy link
Contributor

@leissbua - How did you reproduce the error that led to the proposed change?

@leissbua
Copy link
Contributor Author

@ADDISON74 we experienced deprecation warnings, that first parameter passed to can not be null. From my pov as null can no longer be passed this has to be fixed in general for all strpos strlen and so on.

Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steps to reproduce would be nice.

null seems to be a possible return type ...

    public function getDefaultValue()
    {
        return $this->_getData('default_value');
    }

@kiatng kiatng merged commit 387613e into OpenMage:main Oct 28, 2024
18 checks passed
fballiano added a commit to MahoCommerce/maho that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ImportExport Relates to Mage_ImportExport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants