Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better sitemap configuration #4308

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Better sitemap configuration #4308

wants to merge 12 commits into from

Conversation

sreichel
Copy link
Contributor

Description (*)

Added option to not add products/categories/csm-pages to xml sitemap. Fixed a bug in admin/system/config where options depend on wrong field.

Related Pull Requests

  1. See Admin config: added input validation & hide disabled options #4232

Manual testing scenarios (*)

  1. test options at admin - system - config - catalog - sitemap
  2. generate sitemap

@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: Sitemap Relates to Mage_Sitemap phpstan labels Oct 25, 2024
@kiatng
Copy link
Contributor

kiatng commented Oct 25, 2024

I cannot see how some changes are related to sitemap. It'll be nice to have separate PRs for those.

@sreichel
Copy link
Contributor Author

What should i roll back? Its only some added tests and 2-3 changes to getStoreConfligFlag. And some typos.

# Conflicts:
#	.phpstan.dist.baseline.neon
#	app/code/core/Mage/Catalog/Model/Product.php
#	tests/unit/Mage/Sitemap/Model/SitemapTest.php
@sreichel sreichel mentioned this pull request Oct 29, 2024
@sreichel
Copy link
Contributor Author

sreichel commented Nov 6, 2024

I cannot see how some changes are related to sitemap. It'll be nice to have separate PRs for those.

Moved some changes to #4321. Lets merge it first.

@sreichel sreichel requested review from kiatng and addison74 November 23, 2024 10:01
# Conflicts:
#	app/code/core/Mage/Sitemap/etc/system.xml
#	tests/unit/Mage/Sitemap/Model/SitemapTest.php
@sreichel
Copy link
Contributor Author

sreichel commented Dec 9, 2024

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: Sitemap Relates to Mage_Sitemap enhancement phpstan phpunit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants