Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated functionality: preg_replace() #4311

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ADDISON74
Copy link
Contributor

This fixes issue #4310.

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Oct 25, 2024
@ADDISON74 ADDISON74 linked an issue Oct 26, 2024 that may be closed by this pull request
@sreichel sreichel added the 3rd-party Related to 3rd-party code or issues with customization label Oct 27, 2024
Replacement nulli-coalescing operator with string casting.
@sreichel
Copy link
Contributor

sreichel commented Oct 27, 2024

see few lines later ... $namePrefix should not be empty ...

            // default value
            $html .= '<td class="use-default">';
            $html .= '<input id="' . $id . '_inherit" name="'
                . $namePrefix . '[inherit]" type="checkbox" value="1" class="checkbox config-inherit" '
                . $inherit . ' onclick="toggleValueElements(this, Element.previous(this.parentNode))" /> ';
            $html .= '<label for="' . $id . '_inherit" class="inherit" title="'
                . htmlspecialchars($defText) . '">' . $checkboxLabel . '</label>';
            $html .= '</td>';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd-party Related to 3rd-party code or issues with customization Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP 8.4] Deprecated functionality: preg_replace()
2 participants