-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use transliterator_transliterate
to generate "url_key"
#4315
Open
sreichel
wants to merge
17
commits into
OpenMage:main
Choose a base branch
from
sreichel:slugger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cosmetic change - added method Mage_Catalog_Model_Category_Url
…nd Mage_Catalog_Model_Url - moved duplicate code tp parent
github-actions
bot
added
Component: Core
Relates to Mage_Core
Component: Catalog
Relates to Mage_Catalog
Component: ImportExport
Relates to Mage_ImportExport
composer
Relates to composer.json
labels
Oct 27, 2024
sreichel
changed the title
Used
Use Oct 27, 2024
transliterator_transliterate
to generate "url_key"transliterator_transliterate
to generate "url_key"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Catalog
Relates to Mage_Catalog
Component: Core
Relates to Mage_Core
Component: ImportExport
Relates to Mage_ImportExport
composer
Relates to composer.json
phpstan
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
@luigifab had a great idea to use
intl
-extension for generating url key with translating all special chars. For me the PR did not work, so tried myself.This is a non-BC-breaking try of it. It does not change method-signaturer and should be BC-safe. (I did not add all features of #1631. That could be done in another PR.)
To not reinvent the wheel for locale-mapping if have added
symfony/string
that exactly does what we need.See: https://symfony.com/doc/current/string.html#slugger
Related Pull Requests
Manual testing scenarios (*)
Test product/category before and after ...
Before url-key
After url-key
en_US
de_DE
Questions or comments
Locale config in xml should be changed to not have language-specif config in core. Any ideas?Magento already had an unsused config for it ...
Mage_Catalog_Helper_Product_Url::__construct
looks forMage::getConfig()->getNode('default/url/convert');
XML.