Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ACL settings for system config "groups" #4326

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 31, 2024

Fixed Issues (if relevant)

  1. See Adds configurable columns to product grid #3451 (comment)

To add ACL-checks to config groups you have to:

  1. add resource to adminhtml.xml
  2. adds acl_resource node to system.xmls config groups. Eg.
<acl_resource>system/config/sitemap/category</acl_resource>

Example usage: 70312f3

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Sitemap Relates to Mage_Sitemap labels Oct 31, 2024
@sreichel sreichel marked this pull request as draft November 1, 2024 23:00
@github-actions github-actions bot removed the Component: Sitemap Relates to Mage_Sitemap label Nov 6, 2024
@sreichel sreichel marked this pull request as ready for review November 6, 2024 06:52
@kiatng
Copy link
Contributor

kiatng commented Nov 10, 2024

A brief description on how to test this would be helpful.

@sreichel
Copy link
Contributor Author

Example: 70312f3.

@sreichel sreichel requested review from kiatng and addison74 November 19, 2024 06:20
@kiatng
Copy link
Contributor

kiatng commented Nov 19, 2024

I am not sure how to disable a user from accessing a field. Can you explain how to test this PR?

@sreichel
Copy link
Contributor Author

This is not used in core, yet!

I did not want to add acl-resources in that PR.

@empiricompany "asked" for that feature. And imho its very useful for extensions.

To test see linked commit.

@sreichel
Copy link
Contributor Author

sreichel commented Dec 9, 2024

Can you explain how to test this PR?

Is updated description enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants