Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect OAuth nonce_used error when it should be error on inc… #4378

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Nov 24, 2024

…orrect consumer key.

Description (*)

Incorrect error message leads the developer astray and can waste hours on the wrong thing. This PR fixes such a bug.

Manual testing scenarios (*)

I use openmage-shooter to test.

  1. [OpenMage OAuth Server] Add a consumer if none exist.
  2. [DDEV] Install openmage-shooter in your DDEV environment.
  3. [Browser] Open https://openmage.ddev.site/shooter/rest
    • Fill in the OAuth params, on Consumer Key, enter a wrong key.
    • Click save.
    • Error nonce_used:
      image
    • Try again with this PR, error: Could not retrieve a valid Token response from Token URL: oauth_problem=consumer_key_rejected

@kiatng kiatng added the bug label Nov 24, 2024
@github-actions github-actions bot added the Component: Oauth Relates to Mage_Oauth label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Component: Oauth Relates to Mage_Oauth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants