Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan v2 #4405

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

PHPStan v2 #4405

wants to merge 12 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 7, 2024

Description (*)

  • updated to phpstan v2
  • config cleanup
  • removed classes w/ missing interface methods (fatal error)
  • some minor fixes

@sreichel
fatal
72f9395 
- Fatal error:  Class Mage_Adminhtml_Block_Widget_Grid_Block contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Interface::setColumn, Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Interface::getColumn) in /var/www/html/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Block.php on line 23
@sreichel
fatal
4c008f6 
- Fatal error:  Class Mage_Dataflow_Model_Session_Adapter_Http contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Mage_Dataflow_Model_Convert_Adapter_Interface::save) in /var/www/html/app/code/core/Mage/Dataflow/Model/Session/Adapter/Http.php on line 23
@sreichel
fatal
124376c 
- Fatal error:  Class Mage_Dataflow_Model_Convert_Iterator_Http contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Mage_Dataflow_Model_Convert_Adapter_Interface::save) in /var/www/html/app/code/core/Mage/Dataflow/Model/Convert/Iterator/Http.php on line 23
@sreichel
unused
8bd542c
@sreichel
unused
832a98c
@sreichel
baseline
5c9e4c3
@sreichel
phpstan2
908d003
@sreichel
phpmd doc fix
cddc160
@sreichel
baseline
617f6d5
@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: Reports Relates to Mage_Reports Component: lib/Varien Relates to lib/Varien Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: lib/Mage Relates to lib/Mage Component: Adminhtml Relates to Mage_Adminhtml Component: Page Relates to Mage_Page Component: Api PageRelates to Mage_Api Component: Admin Relates to Mage_Admin Component: SalesRule Relates to Mage_SalesRule Component: Wishlist Relates to Mage_Wishlist Component: Shipping Relates to Mage_Shipping Component: Oauth Relates to Mage_Oauth Component: Downloadable Relates to Mage_Downloadable labels Dec 7, 2024
@github-actions github-actions bot added Component: Api2 Relates to Mage_Api2 Component: Media Relates to Mage_Media Component: ImportExport Relates to Mage_ImportExport Component: Directory Relates to Mage_Directory Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Dataflow Relates to Mage_Dataflow Component: GoogleAnalytics Relates to Mage_GoogleAnalytics Component: Install Relates to Mage_Install Component: Uploader Relates to Mage_Uploader Component: lib/* Relates to lib/* composer Relates to composer.json phpstan labels Dec 7, 2024
@sreichel sreichel marked this pull request as draft December 7, 2024 17:02
@justinbeaty
Copy link
Contributor

FYI, I have some updates to the M1 PHPStan plugin that removes some false positive errors and adds some legitimate errors. Will make a PR today or tomorrow.

@sreichel
Copy link
Contributor Author

sreichel commented Dec 7, 2024

Uih. Sounds good. Thanks.

@sreichel
Copy link
Contributor Author

sreichel commented Dec 9, 2024 •
edited
Loading

and adds some legitimate errors

+570 ... that makes me happy 🙄

Great PR! Thanks.

@sreichel sreichel mentioned this pull request Dec 9, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Cleanup Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: GoogleAnalytics Relates to Mage_GoogleAnalytics Component: ImportExport Relates to Mage_ImportExport Component: Install Relates to Mage_Install Component: lib/Mage Relates to lib/Mage Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Media Relates to Mage_Media Component: Oauth Relates to Mage_Oauth Component: Page Relates to Mage_Page Component: PayPal Relates to Mage_Paypal Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Shipping Relates to Mage_Shipping Component: Uploader Relates to Mage_Uploader Component: Usa Relates to Mage_Usa Component: Wishlist Relates to Mage_Wishlist composer Relates to composer.json phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreichel @justinbeaty