Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unwanted "hard" fallback to Prescott in runtime detection of Intel cpus #4268

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

martin-frbg
Copy link
Collaborator

fixes #4267

@martin-frbg martin-frbg added this to the 0.3.25 milestone Oct 18, 2023
@ogrisel
Copy link
Contributor

ogrisel commented Oct 18, 2023

@jeromedockes can you please rebuild this branch of OpenBLAS on your host with DYNAMIC_ARCH enabled and check that the right architecture is detected (e.g. with threadpoolctl)?

@martin-frbg martin-frbg merged commit 5c411ac into OpenMathLib:develop Oct 18, 2023
@jeromedockes
Copy link

jeromedockes commented Oct 18, 2023

@ogrisel sorry for the delay. yes I confirm that the right architecture is detected now. I compiled this

#include <cblas.h>
#include <stdio.h>

void main() { printf("architecture: %s\n", openblas_get_corename()); }

with the develop branch of OpenBLAS (before this PR was merged) I get

architecture: Prescott

and with this branch I get

architecture: Haswell

(and in any case if I compile OpenBLAS without DYNAMIC_ARCH enabled I get architecture: HASWELL

@ogrisel
Copy link
Contributor

ogrisel commented Oct 18, 2023

Thanks very much for the confirmation !

@ogrisel
Copy link
Contributor

ogrisel commented Oct 18, 2023

And thanks @martin-frbg for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detected architecture is Prescott on a recent CPU
3 participants