Fix handling of INF or NAN arguments in S/D/C SCAL #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-frbg
changed the title
markdryan
added a commit
to markdryan/OpenBLAS
that referenced
this pull request
Jul 16, 2024
The following openblas_utest tests fail when the RISCV64_ZVL128B core is enabled. TEST 39/106 sscal:0_nan [FAIL] ERR: test_zscal.c:19 should be true TEST 40/106 sscal:0_nan_inc_2 [FAIL] ERR: test_zscal.c:31 should be true TEST 41/106 sscal:nan_0 [OK] TEST 42/106 sscal:nan_0_inc_2 [OK] TEST 43/106 sscal:0_inf [FAIL] ERR: test_zscal.c:65 should be true TEST 44/106 sscal:0_inf_inc_2 [FAIL] ERR: test_zscal.c:77 should be true This commit fixes the issue by porting the fixes made to riscv64/scal_vector.c in PR OpenMathLib#4729. Signed-off-by: Mark Ryan <[email protected]>
markdryan
added a commit
to markdryan/OpenBLAS
that referenced
this pull request
Jul 16, 2024
The following openblas_utest tests fail when the RISCV64_ZVL128B core is enabled. TEST 39/106 sscal:0_nan [FAIL] ERR: test_zscal.c:19 should be true TEST 40/106 sscal:0_nan_inc_2 [FAIL] ERR: test_zscal.c:31 should be true TEST 41/106 sscal:nan_0 [OK] TEST 42/106 sscal:nan_0_inc_2 [OK] TEST 43/106 sscal:0_inf [FAIL] ERR: test_zscal.c:65 should be true TEST 44/106 sscal:0_inf_inc_2 [FAIL] ERR: test_zscal.c:77 should be true This commit fixes the issue by porting the fixes made to riscv64/scal_vector.c in PR OpenMathLib#4729. Signed-off-by: Mark Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4728