Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AIX build #4950

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix AIX build #4950

merged 2 commits into from
Oct 23, 2024

Conversation

ayappanec
Copy link
Contributor

AIX build with OpenXL broke after PR #4944 with the below errors.

In file included from ../kernel/power/sbgemv_t_vsx.c:31:
In file included from ../kernel/power/sbgemv_common.c:30:
../kernel/power/gemm_common.c:31:18: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
31 | typedef __vector IFLOAT vec_bf16;
| ~~~~~~~~~~~~~~~~ ^
| int
../common.h:310:16: note: expanded from macro 'IFLOAT'
310 | #define IFLOAT bfloat16
| ^
In file included from ../kernel/power/sbgemv_t_vsx.c:31:
In file included from ../kernel/power/sbgemv_common.c:30:
../kernel/power/gemm_common.c:31:18: error: typedef redefinition with different types ('__vector int' (vector of 4 'int' values) vs 'uint16_t' (aka 'unsigned short'))
../common.h:310:16: note: expanded from macro 'IFLOAT'
310 | #define IFLOAT bfloat16
| ^
../common.h:265:18: note: previous definition is here
265 | typedef uint16_t bfloat16;
| ^
In file included from ../kernel/power/sbgemv_t_vsx.c:31:
In file included from ../kernel/power/sbgemv_common.c:30:
../kernel/power/gemm_common.c:31:24: error: expected ';' after top level declarator
31 | typedef __vector IFLOAT vec_bf16;
| ^
| ;
../kernel/power/gemm_common.c:72:13: error: unknown type name 'vec_bf16'
72 | FORCEINLINE vec_bf16 vec_loadN(void *src, BLASLONG n)
| ^

Looks like vector types will not work with typedef 'ed defines in AIX with OpenXL compiler.
Also bool type is used in the sbgemv_common_power10.c and needs the explicit include of stdbool.h in AIX.

@ChipKerchner
Copy link
Contributor

There is also an issue with AIX gcc=10.3. Please hold off merging this until both compilers can be addressed.

@ayappanec
Copy link
Contributor Author

I just addressed the build issues with gcc compiler also.

@martin-frbg martin-frbg added this to the 0.3.29 milestone Oct 23, 2024
@ChipKerchner
Copy link
Contributor

Looks good to me.

@martin-frbg martin-frbg merged commit 72461f1 into OpenMathLib:develop Oct 23, 2024
81 of 84 checks passed
@ayappanec
Copy link
Contributor Author

Thanks for the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants