Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIX build with OpenXL broke after PR #4944 with the below errors.
In file included from ../kernel/power/sbgemv_t_vsx.c:31:
In file included from ../kernel/power/sbgemv_common.c:30:
../kernel/power/gemm_common.c:31:18: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
31 | typedef __vector IFLOAT vec_bf16;
| ~~~~~~~~~~~~~~~~ ^
| int
../common.h:310:16: note: expanded from macro 'IFLOAT'
310 | #define IFLOAT bfloat16
| ^
In file included from ../kernel/power/sbgemv_t_vsx.c:31:
In file included from ../kernel/power/sbgemv_common.c:30:
../kernel/power/gemm_common.c:31:18: error: typedef redefinition with different types ('__vector int' (vector of 4 'int' values) vs 'uint16_t' (aka 'unsigned short'))
../common.h:310:16: note: expanded from macro 'IFLOAT'
310 | #define IFLOAT bfloat16
| ^
../common.h:265:18: note: previous definition is here
265 | typedef uint16_t bfloat16;
| ^
In file included from ../kernel/power/sbgemv_t_vsx.c:31:
In file included from ../kernel/power/sbgemv_common.c:30:
../kernel/power/gemm_common.c:31:24: error: expected ';' after top level declarator
31 | typedef __vector IFLOAT vec_bf16;
| ^
| ;
../kernel/power/gemm_common.c:72:13: error: unknown type name 'vec_bf16'
72 | FORCEINLINE vec_bf16 vec_loadN(void *src, BLASLONG n)
| ^
Looks like vector types will not work with typedef 'ed defines in AIX with OpenXL compiler.
Also bool type is used in the sbgemv_common_power10.c and needs the explicit include of stdbool.h in AIX.