This repository has been archived by the owner on Jun 17, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
- add some comments in how to model 3D visualisers #106
Open
vwaurich
wants to merge
2
commits into
OpenModelica:master
Choose a base branch
from
vwaurich:vis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeas31
suggested changes
May 3, 2019
UsersGuide/source/omedit.rst
Outdated
@@ -707,6 +707,13 @@ Since OpenModelica 1.11 , OMEdit has built-in 3D visualization, | |||
which replaces third-party libraries (such as `Modelica3D | |||
<https://github.com/OpenModelica/Modelica3D>`_) for 3D visualization. | |||
|
|||
OMEdit can visualize geometric primitves from the “\ **Modelica.Mechanics.MultiBody**\ ”-library. | |||
The base model for visualizers is “\ **Modelica.Mechanics.MultiBody.Visualizers.Advanced.Shape**\ ” . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the space before the full stop.
UsersGuide/source/omedit.rst
Outdated
@@ -707,6 +707,13 @@ Since OpenModelica 1.11 , OMEdit has built-in 3D visualization, | |||
which replaces third-party libraries (such as `Modelica3D | |||
<https://github.com/OpenModelica/Modelica3D>`_) for 3D visualization. | |||
|
|||
OMEdit can visualize geometric primitves from the “\ **Modelica.Mechanics.MultiBody**\ ”-library. | |||
The base model for visualizers is “\ **Modelica.Mechanics.MultiBody.Visualizers.Advanced.Shape**\ ” . | |||
CAD-based 3D-animation can be used with a “\ **Shape**\ ” model by setting the “\ **shapeType**\ ”-parameter to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace the hyphen with a space.
UsersGuide/source/omedit.rst
Outdated
The base model for visualizers is “\ **Modelica.Mechanics.MultiBody.Visualizers.Advanced.Shape**\ ” . | ||
CAD-based 3D-animation can be used with a “\ **Shape**\ ” model by setting the “\ **shapeType**\ ”-parameter to: | ||
“\ **modelica://packageName/pathToCADFile.stl**\ ”. | ||
Usually, the CAD-files are stored in the package directory in a folder called “\ **Resources/stl/**\ ” |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A full stop is missing here.
@vwaurich squash the commits to one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.