NMS-15776: Parallelize DNS lookups during audit phase #6276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fooker
reviewed
Jun 27, 2023
...ond/src/main/java/org/opennms/netmgt/provision/service/operations/SaveOrUpdateOperation.java
Outdated
Show resolved
Hide resolved
RangerRick
previously approved these changes
Jun 27, 2023
fooker
previously approved these changes
Jun 28, 2023
Bonrob2
reviewed
Jun 28, 2023
docs/modules/operation/pages/deep-dive/provisioning/scalability.adoc
Outdated
Show resolved
Hide resolved
docs/modules/operation/pages/deep-dive/provisioning/scalability.adoc
Outdated
Show resolved
Hide resolved
docs/modules/operation/pages/deep-dive/provisioning/scalability.adoc
Outdated
Show resolved
Hide resolved
docs/modules/operation/pages/deep-dive/provisioning/scalability.adoc
Outdated
Show resolved
Hide resolved
docs/modules/operation/pages/deep-dive/provisioning/scalability.adoc
Outdated
Show resolved
Hide resolved
docs/modules/operation/pages/deep-dive/provisioning/scalability.adoc
Outdated
Show resolved
Hide resolved
docs/modules/operation/pages/deep-dive/provisioning/scalability.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Bonrob2 <[email protected]>
fooker
previously approved these changes
Jun 28, 2023
RangerRick
suggested changes
Jul 7, 2023
christianpape
dismissed stale reviews from Bonrob2 and fooker
The base branch was changed.
This reverts commit 44c22be.
RangerRick
previously approved these changes
Jul 11, 2023
christianpape
force-pushed
the
jira/NMS-15776-smoke
branch
from
e5b51f1
to
7d5d17d
Compare
|
Converting to Draft, since the smoke-tests are still failing. |
christianpape
force-pushed
the
jira/NMS-15776-smoke
branch
from
7d5d17d
to
aec3bf4
Compare
christianpape
force-pushed
the
jira/NMS-15776-smoke
branch
11 times, most recently
from
4488ac6
to
d59d13f
Compare
christianpape
force-pushed
the
jira/NMS-15776-smoke
branch
from
d59d13f
to
6617ae0
Compare
|
Finally ready for review. |
RangerRick
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes parallelize the DNS lookups for interface addresses in the audit phase. The process waits for the searches to complete in the final call to the completeModelImport() method. This means that timeouts do not add up and delay the entire syncronization process.