Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apparently am doing something weird where I receive packets, edit them,and then send them out again. If a GroupMod already contains buckets will the length be incorrect after replacing them with new buckets.
I think this problem occurs in every function that contains "this->length_ +=", isn't a constructor and doesn't contain the string "add" in the function name. I'm not going to try and change all of them.
I also looked at the of13::FlowMod class since I also use that one a lot, the functions of13::FlowMod::match and of13::FlowMod::instructions technically have the same problem but the length of the of13::FlowMod packet is recalculated in the pack function so there is no benefit to changing them.