ui-core: remove HTMLLabelElement from radio button props

These props are forwarded to an <input> element, they are never passed to a <label> element. Signed-off-by: Simon Ser <[email protected]>
OpenRailAssociation · Jan 10, 2025 · 92bbf29 · 92bbf29
1 parent 1c3c611
commit 92bbf29
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/ui-core/src/components/inputs/RadioButton.tsx b/ui-core/src/components/inputs/RadioButton.tsx
@@ -4,10 +4,7 @@ import cx from 'classnames';
 
 import useFocusByTab from '../../hooks/useFocusByTab';
 
-export type RadioButtonProps = Omit<
-  React.InputHTMLAttributes<HTMLInputElement | HTMLLabelElement>,
-  'value'
-> & {
+export type RadioButtonProps = Omit<React.InputHTMLAttributes<HTMLInputElement>, 'value'> & {
   label: string;
   value: string;
   hint?: string;

diff --git a/ui-core/src/components/inputs/RadioGroup.tsx b/ui-core/src/components/inputs/RadioGroup.tsx
@@ -32,10 +32,7 @@ const RadioGroup = ({
 }: RadioGroupProps) => {
   const [selectedValue, setSelectedValue] = useState<string | undefined>(value);
 
-  const handleOptionChange = (
-    e: ChangeEvent<HTMLInputElement | HTMLLabelElement>,
-    nextOption: RadioButtonProps
-  ) => {
+  const handleOptionChange = (e: ChangeEvent<HTMLInputElement>, nextOption: RadioButtonProps) => {
     if (!readOnly) {
       setSelectedValue(nextOption.value);
       nextOption.onChange?.(e);