Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-core: add label stories #272

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

ui-core: add label stories #272

wants to merge 1 commit into from

Conversation

turnerian2004
Copy link
Contributor

@turnerian2004 turnerian2004 commented Jul 28, 2024 •
edited
Loading

Issue 274

Comment: The Label component has a hint prop. I do not see the value of this prop, since there is no star like in the required story or additional text like in the stories of the components that have a hint prop.

Should the hint prop be removed? Should the Hint component be passed to the Label component as an optional prop?

@turnerian2004 turnerian2004 requested a review from a team as a code owner July 28, 2024 18:43
@turnerian2004 turnerian2004 force-pushed the ian/add-label-stories branch 2 times, most recently from 274cc03 to 078cc44 Compare July 28, 2024 18:53
@turnerian2004 turnerian2004 force-pushed the ian/add-label-stories branch from 078cc44 to 639fe81 Compare July 28, 2024 19:03
@SharglutDev SharglutDev requested a review from kmer2016 July 29, 2024 13:50
clarani
clarani approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested, thanks 🙏 ✅

From what I see, the hasHint props only removes the margin bottom of the label. If you want, you can indeed remove the story Hint (but we should keep the prop in the component since it is usefull, see the component Input for instance).

@clarani clarani enabled auto-merge August 12, 2024 08:03
@kmer2016
Copy link
Contributor

Thank you for this PR.
As mentionned by @clarani here, If you're okay with that, we'll let you remove the story Hint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

@kmer2016 kmer2016 Awaiting requested review from kmer2016

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turnerian2004 @kmer2016 @clarani