core: fix combo box clear icon #650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SarahBellaha <[email protected]>
Wadjetz
requested changes
Oct 28, 2024
| setInputValue(''); | ||
| setSelectedOption(null); | ||
| onSelectSuggestion?.(undefined); | ||
| clearInput(); |
There was a problem hiding this comment.
The clearInput function calls onSelectSuggestion, but I think we just want to reset the internal state of the component. This also causes a bug I detected when using it in SDCM: it’s called initially and, in my case, resets the value (after reloading the page) that was set previously.
Maybe we can create a new function that just resets the internal state without calling onSelectSuggestion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address the issue of the clear icon being displayed even if the input is empty when the ComboBox is initialized with a default value.