Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ESLint v9 #684

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Migrate to ESLint v9 #684

wants to merge 4 commits into from

Conversation

emersion
Copy link
Member

@emersion emersion commented Nov 4, 2024

Two small cleanup commits followed by the migration.

Migrating to the new config file format is required:
https://eslint.org/docs/latest/use/configure/migration-guide

The new config file has been automatically generated with
@eslint/migrate-config.

@emersion emersion requested review from Yohh and SharglutDev November 4, 2024 15:09
@emersion emersion requested a review from a team as a code owner November 4, 2024 15:09
@emersion emersion marked this pull request as draft November 4, 2024 17:24
@emersion emersion self-assigned this Nov 4, 2024
These are not necessary. Newer ESLint versions complain about them.

Signed-off-by: Simon Ser <[email protected]>
The right-hand-side of the expression is never used, because a
non-empty string is always truthy.

Signed-off-by: Simon Ser <[email protected]>
Migrating to the new config file format is required:
https://eslint.org/docs/latest/use/configure/migration-guide

The new config file has been automatically generated with
@eslint/migrate-config.

Signed-off-by: Simon Ser <[email protected]>
@emersion
Copy link
Member Author

emersion commented Nov 6, 2024

Hm, this ends up to be quite the rabbit hole…

I've migrated everything to the new flat config, except eslint-plugin-react-hooks due to facebook/react#28313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant