storybook: disable preserveSymlinks for vite resolve #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preserveSymlinks is for yarn only, it breaks NPM. Signed-off-by: Simon Ser <[email protected]>
|
Lgtm for me but maybe it's better if other devs test it as well ! |
|
It does not work on my machine :/ |
|
It's not a 100% reliable solution, I've seen it fail on my machine as well. It's just that, before this PR it was never working, and now it's working at least some of the time. My guess is that there is something wrong with the watched files, and the reason it works sometimes is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preserveSymlinksis for yarn only, it breaks NPM (keeps an old version of the dependencies around).To test:
npm run watchin ui-manchette and ui-manchette-with-spacetimechartnpm run storybookconsole.log()in theWaypointcomponentBefore this patch, the log would never show up in the console. With this patch, it should live reload and show up.
Works on my machine™ as well as @SharglutDev's.