Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-core: remove HTMLLabelElement from radio button props #762

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

emersion
Copy link
Member

These props are forwarded to an <input> element, they are never passed to a <label> element.

These props are forwarded to an <input> element, they are never
passed to a <label> element.

Signed-off-by: Simon Ser <[email protected]>
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM !

@emersion emersion added this pull request to the merge queue Jan 10, 2025
Merged via the queue into dev with commit 92bbf29 Jan 10, 2025
6 checks passed
@emersion emersion deleted the emr/radio-props branch January 10, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants