front: add some memoization

OpenRailAssociation · Sep 17, 2024 · 2d6138c · 2d6138c
1 parent afc5442
commit 2d6138c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/front/src/applications/operationalStudies/components/Scenario/ScenarioContent.tsx b/front/src/applications/operationalStudies/components/Scenario/ScenarioContent.tsx
@@ -1,4 +1,4 @@
-import { useState, useEffect } from 'react';
+import { useState, useEffect, useCallback } from 'react';
 
 import { ChevronRight } from '@osrd-project/ui-icons';
 import cx from 'classnames';
@@ -70,10 +70,13 @@ const ScenarioContent = ({
     removeTrains,
   } = useScenarioData(scenario, timetable, infra);
 
-  const toggleMicroMacroButton = (isMacroMode: boolean) => {
-    setIsMacro(isMacroMode);
-    setCollapsedTimetable(isMacroMode);
-  };
+  const toggleMicroMacroButton = useCallback(
+    (isMacroMode: boolean) => {
+      setIsMacro(isMacroMode);
+      setCollapsedTimetable(isMacroMode);
+    },
+    [setIsMacro, setCollapsedTimetable]
+  );
 
   const [ngeDto, setNgeDto] = useState<NetzgrafikDto>();
   const [ngeUpsertedTrainSchedules, setNgeUpsertedTrainSchedules] = useState<

diff --git a/front/src/applications/operationalStudies/hooks/useScenarioData.ts b/front/src/applications/operationalStudies/hooks/useScenarioData.ts
@@ -149,7 +149,7 @@ const useScenarioData = (
     [trainSchedules]
   );
 
-  const removeTrains = (_trainIdsToRemove: number[]) => {
+  const removeTrains = useCallback((_trainIdsToRemove: number[]) => {
     setTrainSchedules((prev) => {
       const trainSchedulesById = mapBy(prev, 'id');
       _trainIdsToRemove.forEach((trainId) => {
@@ -173,7 +173,7 @@ const useScenarioData = (
       });
       return newProjectedTrainsById;
     });
-  };
+  }, []);
 
   useEffect(() => {
     dispatch(updateTrainIdUsedForProjection(undefined));