table, trains after midnight #8334
Merged
Commits on Sep 17, 2024
-
front: write unit tests for formatSchedule
Signed-off-by: Valentin Chanas <[email protected]>
-
front: write unit tests for transformRowDataOnChange
No change in behavior, just testing the previous behavior of the simulation input table, when a value changes. Signed-off-by: Valentin Chanas <[email protected]>
-
front: refactor upsertViaFromSuggestedOP
- using lodash pick to simplify the object construction - no need to lookup twice to find the corresponding pathStep - we don’t need to create copies of the pathSteps array since we are using immer to handle immutability for us - extracting the reducer logic in buildPathStepFromSuggestedOp to be reused Signed-off-by: Valentin Chanas <[email protected]>
-
front: handle train schedule with times exceeding midnight
Signed-off-by: Valentin Chanas <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.