Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: add stop type in stdcm #8656

Merged
merged 1 commit into from
Sep 26, 2024
Merged

front: add stop type in stdcm #8656

merged 1 commit into from
Sep 26, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Aug 30, 2024 •
edited
Loading

closes #8681

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (2fb84ae) to head (15b0d5d).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@              Coverage Diff              @@
##                dev    #8656       +/-   ##
=============================================
+ Coverage     37.13%   67.28%   +30.15%     
  Complexity     2241     2241               
=============================================
  Files          1261      663      -598     
  Lines        115754    48743    -67011     
  Branches       3274     2127     -1147     
=============================================
- Hits          42982    32796    -10186     
+ Misses        70821    15136    -55685     
+ Partials       1951      811     -1140
Flag Coverage Δ
core 74.79% <ø> (ø)
editoast 72.37% <ø> (-0.02%) ⬇️
front ?
gateway 2.22% <ø> (ø)
osrdyne 2.57% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/front/add-stop-type-in-stdcm branch from 65b08ae to fb25eb4 Compare September 5, 2024 16:30
@Akctarus Akctarus force-pushed the tmn/front/add-stop-type-in-stdcm branch 4 times, most recently from c847af7 to d330d87 Compare September 18, 2024 10:16
@Akctarus Akctarus marked this pull request as ready for review September 18, 2024 10:16
@Akctarus Akctarus requested a review from a team as a code owner September 18, 2024 10:16
@Akctarus Akctarus force-pushed the tmn/front/add-stop-type-in-stdcm branch 13 times, most recently from cd66e63 to e47b977 Compare September 23, 2024 09:16
@Akctarus Akctarus changed the title front: add stop type selector in stdcm front: add stop type in stdcm Sep 23, 2024
@Caracol3
Copy link

Nice work ! :-)
I spotted one thing. When you have selected 'service stop' and then 'driver switch' or the opposite, there is no reset of the duration. I think we should reajust the duration of the default stop when changing a type.

SharglutDev
SharglutDev reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, left some comments

front/src/applications/stdcmV2/components/StdcmVias.tsx Show resolved Hide resolved
front/public/locales/en/stdcm.json Outdated Show resolved Hide resolved
front/src/styles/scss/applications/stdcmV2/_card.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/stdcmV2/_card.scss Show resolved Hide resolved
front/src/styles/scss/applications/stdcmV2/_card.scss Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/components/StdcmInputVia.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/components/StdcmVias.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/components/StdcmVias.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/components/StdcmInputVia.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx Show resolved Hide resolved
@Caracol3
Copy link

Good job !
I have just one thing with the behavior of the selector when we hover it after selection.
There is a big arrow instead of our icon.
image

@Akctarus Akctarus mentioned this pull request Sep 26, 2024
Open
@Akctarus Akctarus force-pushed the tmn/front/add-stop-type-in-stdcm branch from 6f657c9 to bd5ad50 Compare September 26, 2024 10:23
@Akctarus Akctarus force-pushed the tmn/front/add-stop-type-in-stdcm branch from bd5ad50 to 9ee9663 Compare September 26, 2024 10:44
@Akctarus
Copy link
Contributor Author

Good job ! I have just one thing with the behavior of the selector when we hover it after selection. There is a big arrow instead of our icon. image

It has been fixed in another PR

Caracol3
Caracol3 approved these changes Sep 26, 2024
View reviewed changes
Copy link

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (tested)

@Akctarus Akctarus force-pushed the tmn/front/add-stop-type-in-stdcm branch from 9ee9663 to 7b0546e Compare September 26, 2024 10:47
SharglutDev
SharglutDev approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job ! Some UI issues remain (not from the PR), they have been added in the meta issue

@Akctarus Akctarus force-pushed the tmn/front/add-stop-type-in-stdcm branch from 7b0546e to 15b0d5d Compare September 26, 2024 10:53
@Akctarus Akctarus added this pull request to the merge queue Sep 26, 2024
Merged via the queue into dev with commit a5e9ca2 Sep 26, 2024
23 checks passed
@Akctarus Akctarus deleted the tmn/front/add-stop-type-in-stdcm branch September 26, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@Caracol3 Caracol3 Caracol3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add selector for stop type in STDCM
4 participants
@Akctarus @codecov-commenter @Caracol3 @SharglutDev