Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: work schedule projection endpoint #8794

Merged
merged 1 commit into from
Sep 18, 2024
Merged

editoast: work schedule projection endpoint #8794

merged 1 commit into from
Sep 18, 2024

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Sep 6, 2024 •
edited
Loading

closes #8642

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.43066% with 9 lines in your changes missing coverage. Please review.

Project coverage is 37.06%. Comparing base (f210693) to head (201a07e).
Report is 19 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/common/api/generatedEditoastApi.ts 86.20% 4 Missing ⚠️
editoast/editoast_authz/src/builtin_role.rs 0.00% 2 Missing ⚠️
editoast/src/views/work_schedules.rs 97.77% 2 Missing ⚠️
front/src/config/openapi-editoast-config.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #8794      +/-   ##
============================================
+ Coverage     36.96%   37.06%   +0.09%     
  Complexity     2211     2211              
============================================
  Files          1256     1259       +3     
  Lines        114423   114701     +278     
  Branches       3182     3192      +10     
============================================
+ Hits          42297    42510     +213     
- Misses        70235    70290      +55     
- Partials       1891     1901      +10
Flag Coverage Δ
core 74.79% <ø> (-0.05%) ⬇️
editoast 72.57% <96.26%> (+0.11%) ⬆️
front 15.00% <83.33%> (+0.09%) ⬆️
gateway 2.20% <ø> (ø)
osrdyne 2.60% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anisometropie anisometropie force-pushed the vcs/project-maintainance branch 5 times, most recently from 0382418 to c7e93d0 Compare September 11, 2024 15:54
@anisometropie anisometropie marked this pull request as ready for review September 11, 2024 15:57
@anisometropie anisometropie requested a review from a team as a code owner September 11, 2024 15:57
woshilapin
woshilapin requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just a small comment.

editoast/src/views/work_schedules.rs Outdated Show resolved Hide resolved
@anisometropie anisometropie force-pushed the vcs/project-maintainance branch 2 times, most recently from cf2c011 to 28aa52f Compare September 12, 2024 07:55
flomonster
flomonster requested changes Sep 13, 2024
View reviewed changes
editoast/src/views/work_schedules.rs Outdated Show resolved Hide resolved
editoast/src/views/work_schedules.rs Outdated Show resolved Hide resolved
editoast/src/views/work_schedules.rs Outdated Show resolved Hide resolved
editoast/src/views/work_schedules.rs Outdated Show resolved Hide resolved
@anisometropie anisometropie mentioned this pull request Sep 13, 2024
Open
leovalais
leovalais requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! A few comments, mostly cosmetic. Thanks for the tests!

editoast/openapi.yaml Outdated Show resolved Hide resolved
editoast/src/models/fixtures.rs Outdated Show resolved Hide resolved
editoast/src/models/fixtures.rs Outdated Show resolved Hide resolved
editoast/src/views/work_schedules.rs Outdated Show resolved Hide resolved
editoast/src/views/work_schedules.rs Outdated Show resolved Hide resolved
editoast/src/views/work_schedules.rs Outdated Show resolved Hide resolved
editoast/src/views/work_schedules.rs Outdated Show resolved Hide resolved
@anisometropie anisometropie requested a review from a team as a code owner September 16, 2024 14:34
@anisometropie anisometropie force-pushed the vcs/project-maintainance branch 2 times, most recently from 4c880e0 to 78760b9 Compare September 16, 2024 15:07
@anisometropie anisometropie force-pushed the vcs/project-maintainance branch 2 times, most recently from 7cb4c7d to 939206f Compare September 17, 2024 07:25
woshilapin
woshilapin approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up 👍

flomonster
flomonster approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this PR.

editoast/src/views/work_schedules.rs Outdated Show resolved Hide resolved
@woshilapin woshilapin mentioned this pull request Sep 17, 2024
Merged
leovalais
leovalais approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@anisometropie anisometropie force-pushed the vcs/project-maintainance branch 2 times, most recently from 3043465 to bf038fd Compare September 17, 2024 17:50
SharglutDev
SharglutDev approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@anisometropie anisometropie added this pull request to the merge queue Sep 18, 2024
Merged via the queue into dev with commit be28062 Sep 18, 2024
23 checks passed
@anisometropie anisometropie deleted the vcs/project-maintainance branch September 18, 2024 08:01
@anisometropie anisometropie mentioned this pull request Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion left review comments

@woshilapin woshilapin woshilapin approved these changes

@flomonster flomonster flomonster approved these changes

@leovalais leovalais leovalais approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement editoast endpoint for work schedules projection
7 participants
@anisometropie @codecov-commenter @emersion @woshilapin @flomonster @leovalais @SharglutDev