-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: imported trains are loaded automatically without refresh #8886
front: imported trains are loaded automatically without refresh #8886
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8886 +/- ##
============================================
- Coverage 37.13% 37.12% -0.01%
Complexity 2211 2211
============================================
Files 1260 1260
Lines 114956 114970 +14
Branches 3223 3223
============================================
- Hits 42689 42688 -1
- Misses 70335 70350 +15
Partials 1932 1932
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f3cb90e
to
0d1770e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job :) lgtm
closes #8679
Once the trains are imported, the new trainSchedules need to be refetched manually with the
upsertTrainSchedules
function