Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: imported trains are loaded automatically without refresh #8886

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Sep 16, 2024

closes #8679

Once the trains are imported, the new trainSchedules need to be refetched manually with the upsertTrainSchedules function

@clarani clarani requested a review from a team as a code owner September 16, 2024 14:23
@clarani clarani marked this pull request as draft September 16, 2024 14:23
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 37.12%. Comparing base (be28062) to head (0d1770e).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...s/operationalStudies/views/ImportTrainSchedule.tsx 0.00% 9 Missing ⚠️
...ortTrainSchedule/ImportTrainScheduleTrainsList.tsx 0.00% 5 Missing ⚠️
...nalStudies/components/Scenario/ScenarioContent.tsx 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8886      +/-   ##
============================================
- Coverage     37.13%   37.12%   -0.01%     
  Complexity     2211     2211              
============================================
  Files          1260     1260              
  Lines        114956   114970      +14     
  Branches       3223     3223              
============================================
- Hits          42689    42688       -1     
- Misses        70335    70350      +15     
  Partials       1932     1932              
Flag Coverage Δ
core 74.79% <ø> (ø)
editoast 72.58% <ø> (-0.01%) ⬇️
front 15.20% <0.00%> (-0.01%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.60% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/8679-imported-trains-display-in-the-train-list branch from f3cb90e to 0d1770e Compare September 18, 2024 08:21
@clarani clarani marked this pull request as ready for review September 18, 2024 08:21
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

@clarani clarani added this pull request to the merge queue Sep 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2024
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job :) lgtm

@clarani clarani added this pull request to the merge queue Sep 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2024
@clarani clarani added this pull request to the merge queue Sep 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
@clarani clarani added this pull request to the merge queue Sep 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
@clarani clarani added this pull request to the merge queue Sep 19, 2024
Merged via the queue into dev with commit 68e0513 Sep 19, 2024
23 checks passed
@clarani clarani deleted the cni/8679-imported-trains-display-in-the-train-list branch September 19, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario page must be refreshed after importing trains
4 participants