Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: provide details when pathfinding failed #9162

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Oct 2, 2024

Close #8038

@github-actions github-actions bot added the area:editoast Work on Editoast Service label Oct 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (0f97f32) to head (17485fe).
Report is 82 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #9162       +/-   ##
=============================================
+ Coverage     37.53%   87.49%   +49.95%     
=============================================
  Files          1256       31     -1225     
  Lines        114937     1535   -113402     
  Branches       3271        0     -3271     
=============================================
- Hits          43141     1343    -41798     
+ Misses        69850      192    -69658     
+ Partials       1946        0     -1946     
Flag Coverage Δ
core ?
editoast ?
front ?
gateway ?
osrdyne ?
railjson_generator 87.49% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch 5 times, most recently from ff93067 to 5e7c5f7 Compare October 10, 2024 21:40
@younesschrifi younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch 3 times, most recently from c72891a to 124328d Compare October 10, 2024 21:53
@younesschrifi younesschrifi marked this pull request as ready for review October 11, 2024 12:53
@younesschrifi younesschrifi requested review from a team as code owners October 11, 2024 12:53
Signed-off-by: Youness CHRIFI ALAOUI <[email protected]>
@younesschrifi younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch from 124328d to 17485fe Compare October 11, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: error pathfinding_not_found has not the details provided by core
2 participants