core: add requirement margin for stop on closed signal (conflict detection) #9195
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9195 +/- ##
============================================
+ Coverage 38.45% 38.52% +0.07%
Complexity 2244 2244
============================================
Files 1288 1288
Lines 98449 98454 +5
Branches 3273 3273
============================================
+ Hits 37857 37932 +75
+ Misses 58655 58585 -70
Partials 1937 1937
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bougue-pe
force-pushed
the
peb/core/add_closed_signal_reservation_margin
branch
from
5db36e8
to
7e8ed4e
Compare
| @@ -40,6 +40,8 @@ import mu.KotlinLogging | |||
|
|
|||
| private val logger = KotlinLogging.logger {} | |||
|
|
|||
| const val CLOSED_SIGNAL_RESERVATION_MARGIN = 20.0 | |||
There was a problem hiding this comment.
Could you add some documentation on that constant?
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…ction) 20 s anticipation for the start of resource requirement when stopping on closed signal. Signed-off-by: Pierre-Etienne Bougué <[email protected]>
bougue-pe
force-pushed
the
peb/core/add_closed_signal_reservation_margin
branch
from
7e8ed4e
to
d4e146b
Compare
|
Please review d4e146b: I fixed a little bit the processing of critical distance, as it could lead to use a stop that was before the signalSight in routing requirement (too late |
20 s anticipation for the start of resource requirement when stopping on closed signal.
Fix: #8813