Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: split margins at any scheduled point #9224

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Oct 7, 2024

Margin ranges need to be split at scheduled points for consistency with what the front-end expects.

May fix #8833

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.92%. Comparing base (99094af) to head (40672ec).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #9224   +/-   ##
=========================================
  Coverage     36.91%   36.92%           
  Complexity     2242     2242           
=========================================
  Files          1255     1255           
  Lines        116958   116972   +14     
  Branches       3270     3272    +2     
=========================================
+ Hits          43178    43189   +11     
- Misses        71835    71838    +3     
  Partials       1945     1945           
Flag Coverage Δ
core 74.80% <100.00%> (+0.02%) ⬆️
editoast 72.26% <ø> (-0.02%) ⬇️
front 15.61% <ø> (ø)
gateway 2.22% <ø> (ø)
osrdyne 2.46% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Train can't respect it's schedule even though only one margin is set for the whole path
2 participants