-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix items alignement #9226
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9226 +/- ##
============================================
- Coverage 38.45% 38.44% -0.02%
Complexity 2244 2244
============================================
Files 1288 1288
Lines 98429 98449 +20
Branches 3273 3273
============================================
- Hits 37855 37851 -4
- Misses 58637 58661 +24
Partials 1937 1937
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eb131a3
to
90cbfeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
But ! I think that, overall, changes should be made to the ui-core components to take better account of their placement in the STDCM interface and avoid having to make these kinds of adjustments.
7136c73
to
860fe91
Compare
860fe91
to
05cdaf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, thank you for this fix/enhancement ! LGTM
05cdaf5
to
60d1e85
Compare
60d1e85
to
9e55638
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested. Some things need to be perfected but issues have been created for that
Signed-off-by: Clara Ni <[email protected]>
9e55638
to
e11d21d
Compare
closes #9225
The css could be cleaner if we were able to modify the style of the inputFieldWrapper of the Select component
Before:
After: