Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix items alignement #9226

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 7, 2024

closes #9225

The css could be cleaner if we were able to modify the style of the inputFieldWrapper of the Select component

Before:
image

After:
image

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 75 lines in your changes missing coverage. Please review.

Project coverage is 38.44%. Comparing base (b38f9e2) to head (e11d21d).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...c/applications/stdcmV2/components/StdcmConsist.tsx 0.00% 29 Missing ⚠️
...rc/applications/stdcmV2/components/StdcmOrigin.tsx 0.00% 15 Missing ⚠️
.../src/applications/stdcmV2/components/StdcmCard.tsx 0.00% 9 Missing ⚠️
.../src/applications/stdcmV2/components/StdcmVias.tsx 0.00% 6 Missing ⚠️
...peedLimitByTagSelector/SpeedLimitByTagSelector.tsx 0.00% 6 Missing ⚠️
...pplications/stdcmV2/components/StdcmOpSchedule.tsx 0.00% 3 Missing ⚠️
...tions/stdcmV2/components/StdcmOperationalPoint.tsx 0.00% 3 Missing ⚠️
...plications/stdcmV2/components/StdcmDefaultCard.tsx 0.00% 2 Missing ⚠️
...plications/stdcmV2/components/StdcmDestination.tsx 0.00% 1 Missing ⚠️
.../applications/stdcmV2/components/StdcmStopType.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9226      +/-   ##
============================================
- Coverage     38.45%   38.44%   -0.02%     
  Complexity     2244     2244              
============================================
  Files          1288     1288              
  Lines         98429    98449      +20     
  Branches       3273     3273              
============================================
- Hits          37855    37851       -4     
- Misses        58637    58661      +24     
  Partials       1937     1937              
Flag Coverage Δ
core 74.87% <ø> (ø)
editoast 72.08% <ø> (-0.02%) ⬇️
front 10.13% <0.00%> (-0.01%) ⬇️
gateway 2.19% <ø> (ø)
osrdyne 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/9225-fix-stdcm-card-alignement branch 3 times, most recently from eb131a3 to 90cbfeb Compare October 10, 2024 07:47
@clarani clarani marked this pull request as ready for review October 10, 2024 07:48
@clarani clarani requested a review from a team as a code owner October 10, 2024 07:48
@clarani clarani requested review from Akctarus, SarahBellaha, SharglutDev and theocrsb and removed request for Akctarus October 10, 2024 07:48
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
But ! I think that, overall, changes should be made to the ui-core components to take better account of their placement in the STDCM interface and avoid having to make these kinds of adjustments.

@clarani clarani force-pushed the cni/9225-fix-stdcm-card-alignement branch from 7136c73 to 860fe91 Compare October 10, 2024 09:45
@clarani clarani force-pushed the cni/9225-fix-stdcm-card-alignement branch from 860fe91 to 05cdaf5 Compare October 10, 2024 10:02
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, thank you for this fix/enhancement ! LGTM

@clarani clarani force-pushed the cni/9225-fix-stdcm-card-alignement branch from 05cdaf5 to 60d1e85 Compare October 10, 2024 11:33
@clarani clarani force-pushed the cni/9225-fix-stdcm-card-alignement branch from 60d1e85 to 9e55638 Compare October 10, 2024 11:52
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested. Some things need to be perfected but issues have been created for that

@clarani clarani added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@clarani clarani added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@clarani clarani force-pushed the cni/9225-fix-stdcm-card-alignement branch from 9e55638 to e11d21d Compare October 10, 2024 13:47
@clarani clarani added this pull request to the merge queue Oct 10, 2024
Merged via the queue into dev with commit 104b257 Oct 10, 2024
24 checks passed
@clarani clarani deleted the cni/9225-fix-stdcm-card-alignement branch October 10, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: fix inputs alignement in stdcm cards
6 participants