Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix the issue where the 'More details' button stopped working #9227

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

achrafmohye
Copy link
Contributor

Closes #9181

…ning in the train list.

Signed-off-by: Achraf Mohyeddine <[email protected]>
@achrafmohye achrafmohye requested a review from a team as a code owner October 7, 2024 12:48
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.91%. Comparing base (207ba1e) to head (fbafd33).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...s/trainschedule/components/Timetable/Timetable.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9227      +/-   ##
============================================
- Coverage     36.91%   36.91%   -0.01%     
  Complexity     2242     2242              
============================================
  Files          1255     1255              
  Lines        116958   116959       +1     
  Branches       3270     3270              
============================================
- Hits          43178    43171       -7     
- Misses        71835    71843       +8     
  Partials       1945     1945              
Flag Coverage Δ
core 74.78% <ø> (ø)
editoast 72.24% <ø> (-0.03%) ⬇️
front 15.61% <0.00%> (-0.01%) ⬇️
gateway 2.22% <ø> (ø)
osrdyne 2.46% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this was a regression, maybe we need a test to avoid another regression later?

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@woshilapin woshilapin changed the title Fix the issue where the 'More details' button stopped functionning Fix the issue where the 'More details' button stopped functioning Oct 8, 2024
@woshilapin woshilapin changed the title Fix the issue where the 'More details' button stopped functioning Fix the issue where the 'More details' button stopped working Oct 8, 2024
@woshilapin woshilapin changed the title Fix the issue where the 'More details' button stopped working front: fix the issue where the 'More details' button stopped working Oct 8, 2024
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@clarani
Copy link
Contributor

clarani commented Oct 11, 2024

@woshilapin I think the better way to test this is by an e2e test. The e2e test are planned and developed by @Maymanaf right now, so I think we won't add the test in this PR. But we can do it later, with @Maymanaf :)

@Maymanaf
Copy link
Contributor

@woshilapin I think the better way to test this is by an e2e test. The e2e test are planned and developed by @Maymanaf right now, so I think we won't add the test in this PR. But we can do it later, with @Maymanaf :)

The timetable management tests are planned but not prioritized for now : You can check the order #7706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more details button doesn't work anymore in the train list
7 participants