-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix the issue where the 'More details' button stopped working #9227
base: dev
Are you sure you want to change the base?
Conversation
…ning in the train list. Signed-off-by: Achraf Mohyeddine <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9227 +/- ##
============================================
- Coverage 36.91% 36.91% -0.01%
Complexity 2242 2242
============================================
Files 1255 1255
Lines 116958 116959 +1
Branches 3270 3270
============================================
- Hits 43178 43171 -7
- Misses 71835 71843 +8
Partials 1945 1945
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this was a regression, maybe we need a test to avoid another regression later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
@woshilapin I think the better way to test this is by an e2e test. The e2e test are planned and developed by @Maymanaf right now, so I think we won't add the test in this PR. But we can do it later, with @Maymanaf :) |
The timetable management tests are planned but not prioritized for now : You can check the order #7706 |
Closes #9181