-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add shortslip distance checkbox in timestops #9275
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9275 +/- ##
============================================
- Coverage 38.55% 38.46% -0.10%
Complexity 2244 2244
============================================
Files 1286 1288 +2
Lines 97963 98373 +410
Branches 3256 3273 +17
============================================
+ Hits 37772 37839 +67
- Misses 58260 58597 +337
- Partials 1931 1937 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, works well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested. The name of the columns aren't exactly like in the issue but I guess it's on purpose
e8b7a72
to
06bef62
Compare
Signed-off-by: romainvalls <[email protected]>
06bef62
to
61b0210
Compare
closes #8808