Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add shortslip distance checkbox in timestops #9275

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

RomainValls
Copy link
Contributor

closes #8808

@RomainValls RomainValls requested a review from a team as a code owner October 9, 2024 16:15
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 38.46%. Comparing base (214ceb1) to head (61b0210).
Report is 13 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/modules/timesStops/helpers/utils.ts 7.14% 13 Missing ⚠️
...rc/modules/timesStops/hooks/useTimeStopsColumns.ts 0.00% 7 Missing ⚠️
front/src/modules/timesStops/TimesStopsInput.tsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9275      +/-   ##
============================================
- Coverage     38.55%   38.46%   -0.10%     
  Complexity     2244     2244              
============================================
  Files          1286     1288       +2     
  Lines         97963    98373     +410     
  Branches       3256     3273      +17     
============================================
+ Hits          37772    37839      +67     
- Misses        58260    58597     +337     
- Partials       1931     1937       +6     
Flag Coverage Δ
core 74.88% <ø> (+0.09%) ⬆️
editoast 72.08% <ø> (-0.04%) ⬇️
front 10.13% <4.34%> (-0.08%) ⬇️
gateway 2.22% <ø> (ø)
osrdyne 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, left some comments

front/src/modules/timesStops/helpers/utils.ts Outdated Show resolved Hide resolved
front/src/modules/timesStops/helpers/utils.ts Outdated Show resolved Hide resolved
front/src/modules/timesStops/hooks/useTimeStopsColumns.ts Outdated Show resolved Hide resolved
front/public/locales/fr/timesStops.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works well

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested. The name of the columns aren't exactly like in the issue but I guess it's on purpose

@RomainValls RomainValls force-pushed the rvs/front-add-shortslip-checkbox-in-timestops branch from e8b7a72 to 06bef62 Compare October 10, 2024 10:46
@RomainValls RomainValls force-pushed the rvs/front-add-shortslip-checkbox-in-timestops branch from 06bef62 to 61b0210 Compare October 10, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front: add "short slip distance" check-box next to closed-signal one
4 participants