Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: OSRD → NGE node fixes #9292

Merged
merged 3 commits into from
Oct 11, 2024
Merged

front: OSRD → NGE node fixes #9292

merged 3 commits into from
Oct 11, 2024

Conversation

emersion
Copy link
Member

@emersion emersion commented Oct 10, 2024

See individual commits.

Closes: #8842
Closes: #8926

This will simplify the next commit.

Signed-off-by: Simon Ser <[email protected]>
Instead of creating one NGE node per OP search result, only create
an NGE node if it's actually used by a train run.

Signed-off-by: Simon Ser <[email protected]>
Closes: #8842
@emersion emersion requested a review from a team as a code owner October 10, 2024 13:07
When a path item location is missing a secondary code, editoast
will default to BV/00/null. Reproduce that behavior here.

Signed-off-by: Simon Ser <[email protected]>
Closes: #8926
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested (expect for open data import because of a bug)

@SharglutDev
Copy link
Contributor

Tested also with imports :)

@emersion emersion added this pull request to the merge queue Oct 11, 2024
Merged via the queue into dev with commit e4eef48 Oct 11, 2024
24 checks passed
@emersion emersion deleted the emr/nge-dangling-nodes branch October 11, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants